Hacker Newsnew | past | comments | ask | show | jobs | submit | cabmaddux's commentslogin

Wow, that makes a ton of sense, definitely cleaner than what I've got going now. There are plenty of places to clean it up, but that would be a big one.

Thanks!


True, may just be a neat hack. The opportunity to work with individual elements of an icon independently and the challenge of the constraints was the initial draw to the project. Maybe there would be a use case for the simple icons and icons that would really benefit from coloring individual elements (hence the flags), but I think there are definitely plenty of drawbacks and it's pretty hacky in some places.

I also don't have a great understanding of some of the technical drawbacks and compatibility issues that have been brought up here, so this HN conversation has been an enormous help.

I think you've hit on my main question. Thanks for the feedback and for taking a look!


Definitely good for working on a few weird CSS oddities and helped me get better acquainted with GitHub and Bower. I figured being able to work with individual elements within the icon might be a plus over icon fonts, but definitely not as reliable. Otherwise, I also couldn't come up with much over SVG either. Thanks for the feedback!


Thanks very much! I had no idea at all, I'll definitely look into it. Great to hear there's another positive for the project.

I'll take a look back at the email and download icons, good eye.


Yeah there are three currency icons that change a lot between browsers because part of the icon is a character. Definitely doesn't really work. Having trouble finding a way to create the central shape with the 3 available elements. May need to scratch them until I can.

Thanks for taking a look at it!


Thanks! I've tested "stopped" states and have it on my ToDo list, but need to just take a moment and get it done.


True, thanks for catching that! I'll fix it up.


There are some more problems with the flags. The colours of the french and german flag are in the wrong order. The icelandic and norwegian flags are missing the white line around the cross. The class for the netherlands shouldn't be lb-flag-holland.


For sure, thanks for taking a look! And good eye on the French flag! I'll get that fixed up.

I'll make sure to add license info to that demo/download page. Thanks again, a huge help!


Aditionally, with the flags, I noticed that you have Switzerland as a rectangle. I know that's not an uncommon representation of it, but its flag is actually a square.

Just an fyi :)


And in the "pedantic++" category: check out flag proportions, too. See for example https://flagspot.net/flags/nl-lu.html, which explains the difference between the flags of Monaco and Indonesia (buried in a discussion about the flags of the Netherlands and Luxembourg): same colors, but different proportions.

So, Belgium should be 13:15 (https://flagspot.net/flags/be.html, for US flags 10:19 seems best for all uses (https://flagspot.net/flags/us-size.html#prop), etc.

But that certainly is just a fyi :)


True, a great point. It's not a bad creative outlet.

Thanks for taking a look!


Thanks! I agree might be interesting to try to capitalize further on animating/coloring individual elements and work on scalability. Just trying to gauge how much time to invest.

The feedback is a huge help!


Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: