Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Don't send an embarrassing company-wide email about how someone ate your lunch. I'm still working there after 6 years, but I get reminded about it now and then.

But seriously, focus on learning from your peers as much as possible. Don't worry about what others think of you or your code. You shouldn't take code reviews personally. Seek objectively simple solutions to problems.

Good luck and may you find fulfillment in your new job!



Also don't just do what code review comments tell you to.

If you disagree, state that and tell them why. Maybe you know something they don't about why you did something the way you did. Maybe they are just wrong. Maybe there's some business requirement you know that they don't or vice versa.

Also the other bit of not making changes just because they tell you to is this, you need to understand why you're making the change. This way you won't make the mistake again and you'll learn. You may stop doing the thing again if they comment it enough times and you internalize it, but that's not understanding, that's pattern recognition and won't help you be a better dev.

Code reviews are a two way street and a great learning opportunity. Use them to your advantage! :D


Embarrassment? That's your lunch! At some point you have to take a stand and defend yourself against these animals that knowingly eat another persons lunch. What's next? First it's lunch, then it's your car, your identity, then your 3pm snack!?




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: