Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I strongly oppose that. PRs should be without emojis, you're not there to play emotional games. If you make a statement, the receiver of that statement should consider that to be objective, straight forward and well meaning.

If you need to use emojis in code reviews, you have distrust, or perhaps other bigger problems in your team.

Ask yourself this question "Why do I need to add an emoji?" and introspect the reasons. Usually those reasons are "Well, what if other person is offended by this? What if my statement is too strong?".



It’s more just joking around with each other. Sometimes I’ll leave comments like:

“Had no idea you could use x library like this, awesome! :fire: :party: just make sure you’ve also considered y!”

Or if somebody made a simple typo that they’ll easily recognize, they get some kind of silly emoji.

Of course it’s different for comments like “This function seems to be doing too much, making it hard to read, I think it should be refactored to work like ...”. Those ones aren’t like the lighthearted ones, so it would be inappropriate to use emojis there.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: