Hacker Newsnew | past | comments | ask | show | jobs | submitlogin
Open Source Realtime Voice Changer (github.com/w-okada)
69 points by liumaiyi on May 23, 2023 | hide | past | favorite | 27 comments


Looks interesting, but there are aspects about how it's presented and needs to be downloaded that is a bit questionable.

1) If this is not meant for just a Japanese audience, then at least have an obvious English translation.

Google translate is doing an OK job, so at least put that up (just indicate machine translation).

2) Directing people to download from Google Drive or Hugging Face seems less than ideal.

SourceForge (https://sourceforge.net/) might be another acceptable option. Both because it can be used to mirror what is at GitHub and can be used to host larger files (though still a depends type of thing). At the very least, they are more well known and trusted.



You are right, though kind of easy to miss, relative to everything on that page. Maybe it should say English translation or English Readme in larger letters for the non-attentive people :-)


Ah, this is just a client for remote services, which aren't necessarily open source or trustworthy.

Clear labelling of anti-features (like “relies on non-Free network services”) really is a killer feature of F-Droid. I hope Flathub copies.


You're wrong. This is a client for local models. There is just an option to host it on a server.


Most commit messages are just "update" :(

https://github.com/w-okada/voice-changer/commits/master


IMO, in small/solo development projects, you really don't need particularly descriptive git messages.

I'll frequently commit 40 disparate changes under "stuff" in my personal projects. It's never been a problem. No real need to LARP a big software project with many developers.


Hard disagree. "The smallest group of programmers is you, and yourself a week later."


Not really been a problem I've run into. I've been working like this (with git) for a good decade, and longer than that with SVN and CVS.

If anything, I think that's more symptomatic of poorly structured work and questionable planning.


Having good commit messages is symptomatic of poorly structured work and poor planning? That's a weird take, to be honest.


If your productivity completely falls apart without good commit messages (or any particular tool, say git), that is symptomatic of poorly structured work and poor planning.


I don't think anyone has made the argument that commit messages are the sole aspect of good project management.


Until you come back to it and forget what you were doing


Reviewing recent diffs has always been far more helpful for me.


You can always just read the code. I'm not really sure what git commit messages would contribute other than misinformation at that point.


Code tells you what it does.

The commit message tells you what you meant it to do. When fixing problems in complex systems this can be vital.


To be fair, function names also tells you what the code is intended to do.

Git based workflows were not the missing technology that finally unlocked the development of complex systems. We wrote complex code before we had git annotate, even before version control systems were widely adopted.


It was considered good practise to write meaningful commit comments from the very first version control systems, long before git was invented.

Source: I have had commits rejected on code review for insufficiently descriptive commit messages in RCS, SCCS, Visual SourceSafe and CVS and probably others before git was first invented.


In your solo projects (which is the context for this discussion), who is doing these code reviews?

What is a sane practice varies immensely with the scale and scope of the project. Many things that are nearly mandatory for large scale development are pointless obstacles in small scale development.


I mean git doubles as cloud for me to hop between machines and keep working on a project... So I literally just "." most of the time lol


I personally prefer to use '.' to avoid the no commit message warning


Oh man. That's not just me? Haha nice.


Sounds interesting, but are there more examples? The videos on twitter show almost no changes from the input voice to the generated output.


Looks cool but someone needs to step up and provide translations to other languages if they seek additional interest from others.


README is also available in english: https://github.com/w-okada/voice-changer/blob/master/README_...

Also, Google Translate works quite well on GitHub: https://github-com.translate.goog/w-okada/voice-changer/blob...


Is there any documentation available in English? All I see is Japanese.





Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: