> What you have encountered is actually one of the necessary steps to really become "a senior developer". And congratulations, you have already passed the biggest part of that hurdle: becoming aware of the issue.
Fully agree. I tell people, if you cannot be humble about your code, you're going to deter yourself and others. It's okay to admit you may have "screwed up" (mistakes happen to everyone, even in production) the big thing to do is learn what was wrong, and if there's any steps you could take moving forward to avoid that mistake, the person commenting on your mistake probably made the same mistake, and worse it made it into production and now its ingrained in them.
Developers become adamant to prevent issues they or fellow team mates have ran into, even seasoned developers run into issues. Hell, even architects, and I've seen CTO's do the dumbest decision making.
+1 on the above. Your code is not you, and everyone makes mistakes. Literally the only singular person I couldn't work with was with the most blindly arrogant person I ever interacted with, and I left that job because of it. That's over several decades as a developer. In the end, your code isn't perfect and there will be better alternatives on how to do things discovered over time. Most of what you write won't live more than a decade, and if it does, feel sorry for anyone that has to deal with it.
It's about doing the best you can, and helping others to do the same. Critique on your code isn't critique about you as a person. Sometimes personal statements can leak in and that's different. I find that for the most part, critiques are only about the code, and it's the author that turns things personal which is where any argument is already lost.
This doesn't mean you have to agree with a given assessment, and they don't have to agree with your approach. As opposed to some other comments on this post, I will say that I think the best way to learn how to deal with it is to just keep working, and when you do feel yourself getting emotional, take a step back and review. You rarely are on the spot to respond at that moment, especially for typical PR processes and feedback. Try to put yourself in the mindset to assume at first you are wrong, and second that you are not interpreting the message as intended. Interpret the best possible view of the person and the message sent.
It's really hard to put yourself in that mindset, and it definitely takes practice, time and experience. The best thing that you can do from the start, is stay quiet, step away for a moment, and re-evaluate before responding if you feel emotional.
Fully agree. I tell people, if you cannot be humble about your code, you're going to deter yourself and others. It's okay to admit you may have "screwed up" (mistakes happen to everyone, even in production) the big thing to do is learn what was wrong, and if there's any steps you could take moving forward to avoid that mistake, the person commenting on your mistake probably made the same mistake, and worse it made it into production and now its ingrained in them.
Developers become adamant to prevent issues they or fellow team mates have ran into, even seasoned developers run into issues. Hell, even architects, and I've seen CTO's do the dumbest decision making.