Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

My biggest beef with the former solution is that resultsEntries is unnecessarily stored in a variable, and between its declaration and use there is an interspersed declaration of a general utility function. I might have inlined that one as well. This is what harms readability the most. Code should be arranged general-to-specific, and this example violates that.

Although given that there are only two properties to process, the gopher-style assignment code preferred by the author would suffice anyway.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: