My other favourite of trivial code that's broken: returning the same Iterator instance in Iterable.iterator()
I remember hibernate recommending using static hash. In order to prevent saving entities changing hash values.
My other favourite of trivial code that's broken: returning the same Iterator instance in Iterable.iterator()