Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

> Use emoji to clarify tone. Compare “:sparkles: :sparkles: Looks good :+1: :sparkles: :sparkles:” to “Looks good.”

Or, you know, write "Looks great!"

Exclamation mark is the OG emoji



Or formalize phrases. The Google review guide [1] defines some phrases and as such there is no question about the tone of it. Prefix comments on non-essential parts of the commit with "Nit:", approve the changes with "LGTM" (looks good to me).

[1] https://google.github.io/eng-practices/review/


That's boring. As a form of protest, I'm going to do all future reviews in emoji only.


On smaller projects I've done code reviews with reaction GIFs (although always with people who knew me and my humour well).




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: