Hacker News
new
|
past
|
comments
|
ask
|
show
|
jobs
|
submit
login
Kwantuum
on Feb 19, 2020
|
parent
|
context
|
favorite
| on:
How to write the perfect pull request (2015)
Or formalize phrases. The Google review guide [1] defines some phrases and as such there is no question about the tone of it. Prefix comments on non-essential parts of the commit with "Nit:", approve the changes with "LGTM" (looks good to me).
[1]
https://google.github.io/eng-practices/review/
xvector
on Feb 19, 2020
[–]
That's boring. As a form of protest, I'm going to do all future reviews in emoji only.
dharmab
on Feb 20, 2020
|
parent
[–]
On smaller projects I've done code reviews with reaction GIFs (although always with people who knew me and my humour well).
Guidelines
|
FAQ
|
Lists
|
API
|
Security
|
Legal
|
Apply to YC
|
Contact
Search:
[1] https://google.github.io/eng-practices/review/